Skip to content

GPU: Simplify kernel Call interface, remove intermediate classes and headers where possible#14205

Merged
davidrohr merged 2 commits intoAliceO2Group:devfrom
davidrohr:PR
Apr 20, 2025
Merged

GPU: Simplify kernel Call interface, remove intermediate classes and headers where possible#14205
davidrohr merged 2 commits intoAliceO2Group:devfrom
davidrohr:PR

Conversation

@davidrohr
Copy link
Collaborator

@davidrohr davidrohr commented Apr 20, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@davidrohr davidrohr force-pushed the PR branch 2 times, most recently from 4aabe65 to 072e4a0 Compare April 20, 2025 17:42
@alibuild
Copy link
Collaborator

alibuild commented Apr 20, 2025

Error while checking build/O2/fullCI_slc9 for 4aabe65 at 2025-04-20 20:39:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
grep: error-log.txt: binary file matches
/sw/SOURCES/O2/14205-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerHost.cxx:154:21: error: use '= default' to define a trivial destructor [modernize-use-equals-default]
/sw/SOURCES/O2/14205-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerHost.cxx:194:27: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Apr 20, 2025

Error while checking build/O2/fullCI_slc9 for 072e4a0 at 2025-04-20 21:18:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/14205-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerHost.cxx:154:21: error: use '= default' to define a trivial destructor [modernize-use-equals-default]
/sw/SOURCES/O2/14205-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerHost.cxx:194:27: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@davidrohr davidrohr merged commit 73a0935 into AliceO2Group:dev Apr 20, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@f3sch f3sch Awaiting requested review from f3sch f3sch is a code owner

@bazinski bazinski Awaiting requested review from bazinski bazinski is a code owner

@wille10 wille10 Awaiting requested review from wille10 wille10 is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davidrohr @alibuild